sodonnel commented on code in PR #3345: URL: https://github.com/apache/ozone/pull/3345#discussion_r863668395
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReconstructECContainersCommand.java: ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.protocol.commands; + +import java.util.List; +import java.util.stream.Collectors; + +import com.google.protobuf.ByteString; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.ReconstructECContainersCommandProto; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.ReconstructECContainersCommandProto + .Builder; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.SCMCommandProto.Type; + +import com.google.common.base.Preconditions; + +/** + * SCM command to request reconstruction of EC containers. + */ +public class ReconstructECContainersCommand + extends SCMCommand<ReconstructECContainersCommandProto> { + + private final long containerID; + private final List<DatanodeDetails> sourceDatanodes; + private final List<DatanodeDetails> targetDatanodes; + private final byte[] missingContainerIndexes; Review Comment: > shuflle can scatter the read of data blocks to different datanode, so i believe it has some significance for the performance of the whole ozone cluster , and we need to support it in the future. There is no plan to try to support this. It makes things too complex for negligible gains. We only have one container per pipeline, so each time a new container is allocated, it gets new nodes in a random order. So over many containers we will see the data fairly evenly spread without having to worry about shuffling writes inside one container group. ########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReconstructECContainersCommand.java: ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.protocol.commands; + +import java.util.List; +import java.util.stream.Collectors; + +import com.google.protobuf.ByteString; +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.ReconstructECContainersCommandProto; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.ReconstructECContainersCommandProto + .Builder; +import org.apache.hadoop.hdds.protocol.proto + .StorageContainerDatanodeProtocolProtos.SCMCommandProto.Type; + +import com.google.common.base.Preconditions; + +/** + * SCM command to request reconstruction of EC containers. + */ +public class ReconstructECContainersCommand + extends SCMCommand<ReconstructECContainersCommandProto> { + + private final long containerID; + private final List<DatanodeDetails> sourceDatanodes; + private final List<DatanodeDetails> targetDatanodes; + private final byte[] missingContainerIndexes; Review Comment: > shuflle can scatter the read of data blocks to different datanode, so i believe it has some significance for the performance of the whole ozone cluster , and we need to support it in the future. There is no plan to try to support this. It makes things too complex for negligible gains. We only have one container per pipeline, so each time a new container is allocated, it gets new nodes in a random order. So over many containers we will see the data fairly evenly spread without having to worry about shuffling writes inside one container group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
