neils-dev commented on code in PR #3781: URL: https://github.com/apache/ozone/pull/3781#discussion_r998795404
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionMetrics.java: ########## @@ -0,0 +1,253 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.hadoop.hdds.scm.node; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.hadoop.metrics2.MetricsCollector; +import org.apache.hadoop.metrics2.MetricsRecordBuilder; +import org.apache.hadoop.metrics2.MetricsSource; +import org.apache.hadoop.metrics2.annotation.Metric; +import org.apache.hadoop.metrics2.annotation.Metrics; +import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem; +import org.apache.hadoop.metrics2.lib.Interns; +import org.apache.hadoop.metrics2.lib.MetricsRegistry; +import org.apache.hadoop.metrics2.lib.MutableGaugeLong; +import org.apache.hadoop.ozone.OzoneConsts; + +import java.util.HashMap; +import java.util.Map; + +/** + * Class contains metrics related to the NodeDecommissionManager. + */ +@Metrics(about = "Node Decommission Metrics", context = OzoneConsts.OZONE) +public final class NodeDecommissionMetrics implements MetricsSource { + public static final String METRICS_SOURCE_NAME = + org.apache.hadoop.hdds.scm.node.NodeDecommissionMetrics + .class.getSimpleName(); + + @Metric("Number of nodes tracked for decommissioning and maintenance.") + private MutableGaugeLong trackedDecommissioningMaintenanceNodesTotal; + + @Metric("Number of nodes tracked for recommissioning.") + private MutableGaugeLong trackedRecommissionNodesTotal; Review Comment: The significance of `tracked` is coming from the convention in the monitor code which tracks the nodes in the decommissioning and maintenance workflow - `DatanodeAdminMonitorImpl.java` javadoc: _Once an node is placed into tracked nodes, it goes through a workflow where the following happens:_ and the corresponding log outputs, _INFO node.DatanodeAdminMonitorImpl: There are 1 nodes tracked for decommission and maintenance._ Would it be better to continue to use the prefix `tracked`, remove altogether, or perhaps another keyword uniform to the decommissioning/maintenance mode metrics to easily search for with jmx and prometheus? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
