neils-dev commented on code in PR #3781:
URL: https://github.com/apache/ozone/pull/3781#discussion_r998797359
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java:
##########
@@ -82,6 +85,44 @@ public class DatanodeAdminMonitorImpl implements
DatanodeAdminMonitor {
private long unhealthyContainers = 0;
private long underReplicatedContainers = 0;
+ @SuppressFBWarnings(value = "SIC_INNER_SHOULD_BE_STATIC")
+ private final class ContainerStateInWorkflow {
+ private long sufficientlyReplicated = 0;
+ private long unhealthyContainers = 0;
+ private long underReplicatedContainers = 0;
+ private String host = "";
+
+ private ContainerStateInWorkflow(String host,
+ long sufficientlyReplicated,
Review Comment:
Yes, using a new ide. Adjusted formatting for files accordingly.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java:
##########
@@ -82,6 +85,44 @@ public class DatanodeAdminMonitorImpl implements
DatanodeAdminMonitor {
private long unhealthyContainers = 0;
private long underReplicatedContainers = 0;
+ @SuppressFBWarnings(value = "SIC_INNER_SHOULD_BE_STATIC")
+ private final class ContainerStateInWorkflow {
+ private long sufficientlyReplicated = 0;
+ private long unhealthyContainers = 0;
+ private long underReplicatedContainers = 0;
+ private String host = "";
+
+ private ContainerStateInWorkflow(String host,
+ long sufficientlyReplicated,
+ long underReplicatedContainers,
+ long unhealthyContainers) {
+ this.host = host;
+ this.sufficientlyReplicated = sufficientlyReplicated;
+ this.unhealthyContainers = unhealthyContainers;
+ this.underReplicatedContainers = underReplicatedContainers;
+ }
+
+ public void setAll(long sufficiently,
+ long under,
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
