symious commented on PR #3897: URL: https://github.com/apache/ozone/pull/3897#issuecomment-1297942400
@kerneltime @neils-dev Thank you for the review. > Tags are usually fixed strings that are used to segregate metrics (Example: Object count metric with bucket name as tag) Understand, but sometimes it is convenient to set some Strings in Tags, for example, the "NumOpenConnectionsPerUser" from in Hadoop's RPC metrics. In https://github.com/apache/ozone/blob/master/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/http/PrometheusMetricsSink.java#L82, there is a filter on this tag, maybe we need a more general way to solve this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
