kerneltime commented on code in PR #3931:
URL: https://github.com/apache/ozone/pull/3931#discussion_r1013684666
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java:
##########
@@ -287,12 +287,17 @@ public void stop() throws Exception {
if (ozoneManagerServiceProvider != null) {
ozoneManagerServiceProvider.stop();
}
- if (reconDBProvider != null) {
- reconDBProvider.close();
- }
if (reconTaskStatusMetrics != null) {
reconTaskStatusMetrics.unregister();
}
+ if (reconDBProvider != null) {
+ try {
+ LOG.info("Closing Recon Container Key DB.");
+ reconDBProvider.close();
+ } catch (Exception ex) {
+ LOG.error("Recon Container Key DB close failed", ex);
+ }
+ }
isStarted = false;
Review Comment:
why not move it to the very end? mark service as stopped and then close the
DB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
