sodonnel commented on code in PR #3497: URL: https://github.com/apache/ozone/pull/3497#discussion_r1040954307
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReplicateContainerCommand.java: ########## @@ -41,20 +41,28 @@ private final long containerID; private final List<DatanodeDetails> sourceDatanodes; + private final long timeoutMs; Review Comment: If we go with my earlier suggestion of setting the "run by time" in SCM on the command, perhaps rename "timeout" to something like "deadlineEpochMs" or "expiryEpochMs" throughout this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
