sodonnel commented on code in PR #4415:
URL: https://github.com/apache/ozone/pull/4415#discussion_r1143204998
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java:
##########
@@ -409,6 +409,18 @@ private void
validateConfiguration(ContainerBalancerConfiguration conf)
"should be greater than hdds.datanode.du.refresh.period {}",
conf.getBalancingInterval(), refreshPeriod);
}
+
+ // "move.replication.timeout" should be lesser than "move.timeout"
+ if (conf.getMoveReplicationTimeout().toMillis() >=
+ conf.getMoveTimeout().toMillis()) {
+ LOG.warn("hdds.container.balancer.move.replication.timeout {} should " +
+ "be lesser than hdds.container.balancer.move.timeout {}.",
Review Comment:
typo: lesser -> less
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java:
##########
@@ -409,6 +409,18 @@ private void
validateConfiguration(ContainerBalancerConfiguration conf)
"should be greater than hdds.datanode.du.refresh.period {}",
conf.getBalancingInterval(), refreshPeriod);
}
+
+ // "move.replication.timeout" should be lesser than "move.timeout"
+ if (conf.getMoveReplicationTimeout().toMillis() >=
+ conf.getMoveTimeout().toMillis()) {
+ LOG.warn("hdds.container.balancer.move.replication.timeout {} should " +
+ "be lesser than hdds.container.balancer.move.timeout {}.",
+ conf.getMoveReplicationTimeout().toMinutes(),
+ conf.getMoveTimeout().toMinutes());
+ throw new InvalidContainerBalancerConfigurationException(
+ "hdds.container.balancer.move.replication.timeout should " +
+ "be lesser than hdds.container.balancer.move.timeout.");
Review Comment:
typo: lesser -> less
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
