smengcl commented on code in PR #4486:
URL: https://github.com/apache/ozone/pull/4486#discussion_r1152619784
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1200,7 +1200,8 @@ message DeletedKeys {
message PurgeKeysRequest {
repeated DeletedKeys deletedKeys = 1;
- optional string fromSnapshot = 2;
+ // if not null, will purge keys in a snapshot DB instead of active DB
Review Comment:
nit: sorry for the back and forth. I guess `null` was not a concept in
protobuf.
```suggestion
// if set, will purge keys in a snapshot DB instead of active DB
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
