xBis7 commented on PR #4574: URL: https://github.com/apache/ozone/pull/4574#issuecomment-1514984069
@xichen01 You are adding the same metrics twice but this time with a more descriptive name. > So we just need to directly change the Metric name and needn't keep the old Metric name? If we are not changing the metric values, there is no point in keeping the old metric names as well. We are ending up with duplicate entries. > Do you think the suffix is needed for ms, or do we just need to add the suffix for ns? I have no particular preference. If you keep the old values and the numbers were in `ms` just add the `ms` suffix to the metric name. Similarly, if the numbers were referring to `ns`, add the `ns` suffix to the name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
