aryangupta1998 commented on PR #4918: URL: https://github.com/apache/ozone/pull/4918#issuecomment-1597394825
> I wonder if we can detect difference between incorrect configuration and node decommissioning? Potentially it could be confusing for administrators seeing up and running service with incorrect configuration. Hi @ivanzlenko The call to “addOMNodeToPeers()” will come only in case when a node wants to join the Ratis ring that can be a case if a node is bootstrapped or Ratis applies previous transactions which in turn asks to add the old node, so if a node is bootstrapped with invalid configs then we have added a return statement in “addOMNodeToPeers()” which in turn prevents the node from getting added to the Ratis ring and eventually that nodes get shut down and in case of Ratis previous transactions our return statements help to prevent the current node from going down. So, in both cases, administrators won’t see a running service with an incorrect configuration. Also, this is a temporary solution, soon we will be working to handle this case in a proper way where we’ll fix the bootstrap command and also take a Ratis snapshot after decommissioning a node and also handle some other edge cases so that we do not run into Ratis previous transactions issues again. cc @nandakumar131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
