z-bb commented on code in PR #4929:
URL: https://github.com/apache/ozone/pull/4929#discussion_r1237805494


##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientAdapter.java:
##########
@@ -46,9 +46,17 @@ public interface OzoneClientAdapter {
   OzoneFSOutputStream createFile(String key, short replication,
       boolean overWrite, boolean recursive) throws IOException;
 
+  OzoneFSOutputStream createFile(String key, short replication,
+      boolean overWrite, boolean recursive,
+      String ecPolicyName) throws IOException;

Review Comment:
   > Ozone extends FileSystem, and it looks like distcp either talks to a 
DistributedFileSystem (HDFS) or a FileSystem. Therefore I suspect we need to 
change the FileSystem class in Hadoop to have the new parameter first. 
Otherwise, even though we have added the new parameters here, distcp will not 
be able to see them, as it only knows about Filesystem. We cannot cast an 
object in distcp into an Ozone class.
   
   @sodonnel I think this is possible, cc @adoroszlai @ChenSammi 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to