ayushtkn commented on code in PR #5243:
URL: https://github.com/apache/ozone/pull/5243#discussion_r1315224896
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1332,6 +1332,9 @@ public static boolean omInit(OzoneConfiguration conf)
throws IOException,
AuthenticationException {
OMHANodeDetails omhaNodeDetails = OMHANodeDetails.loadOMHAConfig(conf);
String nodeId = omhaNodeDetails.getLocalNodeDetails().getNodeId();
+ // Checking certificate duration validity by using
+ // validateCertificateValidityConfig() in SecurityConfig constructor.
+ new SecurityConfig(conf);
Review Comment:
```new SecurityConfig(conf);``` is doing much more than just validating, can
we refactor the certificate code extraction part & combine with the validation
method into a single method & call that here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
