aryangupta1998 commented on code in PR #5243:
URL: https://github.com/apache/ozone/pull/5243#discussion_r1318197153
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1332,6 +1332,9 @@ public static boolean omInit(OzoneConfiguration conf)
throws IOException,
AuthenticationException {
OMHANodeDetails omhaNodeDetails = OMHANodeDetails.loadOMHAConfig(conf);
String nodeId = omhaNodeDetails.getLocalNodeDetails().getNodeId();
+ // Checking certificate duration validity by using
+ // validateCertificateValidityConfig() in SecurityConfig constructor.
+ new SecurityConfig(conf);
Review Comment:
In the SecurityConfig constructor we're mostly initializing the member
variables and most of them are used in `validateCertificateValidityConfig` so I
don't think there would be too much extra load if we call out an object. If we
try to extract a method for initializing variables related to
`validateCertificateValidityConfig` then also we have to explicitly initialize
each property being used in `validateCertificateValidityConfig`, what do you
suggest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
