sadanand48 commented on code in PR #5274:
URL: https://github.com/apache/ozone/pull/5274#discussion_r1322956869
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/TracingFilter.java:
##########
@@ -71,7 +71,7 @@ public void filter(ContainerRequestContext requestContext,
// written the data to the destination
OutputStream out = responseContext.getEntityStream();
if (out != null) {
- responseContext.setEntityStream(new FilterOutputStream(out) {
+ responseContext.setEntityStream(new PureWrapperOutputStream(out) {
Review Comment:
It makes sense to wrap the outputStream only if tracing is enabled, By
default tracing is disabled
```java
public static final boolean HDDS_TRACING_ENABLED_DEFAULT = false;
```
So this wrapping won't be of any help if disabled since tracer registration
happens only if the above property is true (Please verify this part) , We
should check if Tracing is enabled , only then do the wrap. If it is disabled,
do nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
