ivandika3 commented on code in PR #4585:
URL: https://github.com/apache/ozone/pull/4585#discussion_r1325876852
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/recovery/ReconOMMetadataManager.java:
##########
@@ -47,4 +50,59 @@ public interface ReconOMMetadataManager extends
OMMetadataManager {
* @return true if OM Tables are initialized, otherwise false.
*/
boolean isOmTablesInitialized();
+
+ /**
+ * Return a list of volumes owned by a given user; if user is null, returns
+ * all volumes.
+ *
+ * This method can be optimized by using username as a filter.
+ *
+ * @param startKey the start volume name determines where to start listing
+ * from, this key is excluded from the result. Returns all the volumes if
+ * it's null.
+ * @param maxKeys the maximum number of volumes to return.
+ * @return volumes with starting from <code>startKey</code> limited by
+ * <code>maxKeys</code>
+ */
+ List<OmVolumeArgs> listVolumes(String startKey,
+ int maxKeys) throws IOException;
+
+ /**
+ * Return all volumes in the file system.
+ * @return all the volumes from the OM DB.
Review Comment:
This is referring to `ReconOMMetadataManager#listVolumes()` which is only
used in `RootEntityHandler`. The UI will use
`ReconOMMetadataManager#listVolumes(String startKey, int maxKeys)`. The reason
is to prevent behaviour change in `RootEntityHandler`. So this method will
still return all the volumes in the file system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
