adoroszlai commented on code in PR #5546:
URL: https://github.com/apache/ozone/pull/5546#discussion_r1383904123


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -56,7 +56,7 @@ public final class OzoneConfigKeys {
    * so that a mini cluster is able to launch multiple containers on a node.
    *
    * When set to false (default), container port is fixed as specified by
-   * DFS_CONTAINER_IPC_PORT_DEFAULT.
+   * {@link OzoneConfigKeys#DFS_CONTAINER_IPC_PORT_DEFAULT}.

Review Comment:
   I think this comment has a bug (not introduced in this PR).  When random 
port is disabled, the actual port used is specified by the config 
`DFS_CONTAINER_IPC_PORT`, for which `DFS_CONTAINER_IPC_PORT_DEFAULT` is only 
the default value.
   
   Also, we can omit the class name when linking within the same class.
   
   ```suggestion
      * {@link #DFS_CONTAINER_IPC_PORT}.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to