ChenSammi commented on code in PR #5020:
URL: https://github.com/apache/ozone/pull/5020#discussion_r1384347969
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java:
##########
@@ -486,11 +502,12 @@ private void updateReadUnlockMetrics(Resource resource,
String resourceName) {
// Adds a snapshot to the metric readLockHeldTimeMsStat.
omLockMetrics.setReadLockHeldTimeMsStat(
TimeUnit.NANOSECONDS.toMillis(readLockHeldTimeNanos));
+ updateProcessingDetails(Timing.LOCKSHARED, readLockHeldTimeNanos);
Review Comment:
I feel like this updateReadUnlockMetrics and updateWriteUnlockMetrics lock
held time is inaccurate, for the hold time is saved in Resource object which is
shared between different resoucesNames. Say the Resource is VOLUME_LOCK, if
two clients, each access a different volume concurrently, then this lock hold
time will be calculated by (latest lock release time - earliest lock lock
time).
@tanvipenumudy , could you help to check it if the above is true or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
