ChenSammi commented on code in PR #5020:
URL: https://github.com/apache/ozone/pull/5020#discussion_r1396614116
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OzoneManagerLock.java:
##########
@@ -486,11 +502,12 @@ private void updateReadUnlockMetrics(Resource resource,
String resourceName) {
// Adds a snapshot to the metric readLockHeldTimeMsStat.
omLockMetrics.setReadLockHeldTimeMsStat(
TimeUnit.NANOSECONDS.toMillis(readLockHeldTimeNanos));
+ updateProcessingDetails(Timing.LOCKSHARED, readLockHeldTimeNanos);
Review Comment:
Given currently the OMStateMachine has single thread to execute all write
requests, this inaccurate will not happen. Future, if the single thread is
optimized to multi threads, then this part need a revisit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
