xichen01 opened a new pull request, #5627: URL: https://github.com/apache/ozone/pull/5627
## What changes were proposed in this pull request? - Use the `AggregatedMetrics` replica the `MutableRate` S3G Metrics of `S3GatewayMetrics`. - The `AggregatedMetrics` including `MutableQuantiles` and `MutableMinMax` and `MutableStat` Metrics, the `MutableStat` is same with original `MutableRate` Metrics. - Replacing `MutableRate` with `AggregatedMetrics` ensures that the original `MutableRate` remains unchanged, and adds configurable `MutableQuantiles` and `MutableMinMax` metrics. ### Before ``` [root@VM-8-3-centos ~/community/ozone]$ curl -s http://localhost:9878/prom | grep s3_gateway_metrics | grep -v '#' s3_gateway_metrics_abort_multipart_upload_failure{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_avg_time{hostname="VM-8-3-centos"} 0.0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_num_ops{hostname="VM-8-3-centos"} 0 ``` ### After Default (Add MutableMinMax Metrics): ``` [root@VM-8-3-centos ~/community/ozone]$ curl -s http://localhost:9878/prom | grep s3_gateway_metrics | grep -v '#' s3_gateway_metrics_abort_multipart_upload_failure{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_avg_time{hostname="VM-8-3-centos"} 0.0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_i_max_time{hostname="VM-8-3-centos"} 1.401298464324817E-45 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_i_min_time{hostname="VM-8-3-centos"} 3.4028234663852886E38 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_num_ops{hostname="VM-8-3-centos"} 0 ``` Enable quantiles Metrics: ```xml <property> <name>oozone.s3g.metrics.percentiles.intervals.seconds</name> <value>15</value> </property> ``` ``` [root@VM-8-3-centos ~/community/ozone]$ curl -s http://localhost:9878/prom | grep s3_gateway_metrics | grep -v '#' s3_gateway_metrics_abort_multipart_upload_failure{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns15s50th_percentile_time{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns15s75th_percentile_time{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns15s90th_percentile_time{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns15s95th_percentile_time{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns15s99th_percentile_time{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns15s_num_ops{hostname="VM-8-3-centos"} 0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_avg_time{hostname="VM-8-3-centos"} 0.0 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_i_max_time{hostname="VM-8-3-centos"} 1.401298464324817E-45 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_i_min_time{hostname="VM-8-3-centos"} 3.4028234663852886E38 s3_gateway_metrics_abort_multipart_upload_failure_latency_ns_num_ops{hostname="VM-8-3-centos"} 0 //... ``` ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-9717 ## How was this patch tested? Manually Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
