ivandika3 commented on code in PR #6769:
URL: https://github.com/apache/ozone/pull/6769#discussion_r1630671593
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -302,6 +319,16 @@ export class Overview extends
React.Component<Record<string, object>, IOverviewS
<Col xs={24} sm={18} md={12} lg={12} xl={6} className='summary-font'>
<OverviewCard loading={loading} title='Pending Deleted Keys
Summary' data={deletePendingSummaryData} icon='delete' linkToUrl='/Om'/>
</Col>
+ {scmServiceId &&
+ <Col xs={24} sm={18} md={12} lg={12} xl={6}
className='summary-font'>
+ <OverviewCard title="Storage Container Manager"
loading={loading} data={scmServiceData} icon='file-text'/>
+ </Col>
Review Comment:
```suggestion
<Col xs={24} sm={18} md={12} lg={12} xl={6}>
<OverviewCard title="SCM Service" loading={loading}
data={scmServiceId} icon='file-text'/>
</Col>
```
I think we can simply do these to standardize with other overview card (e.g.
Volumes / Bucket). Similarly to OM service as well.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx:
##########
@@ -230,6 +237,16 @@ export class Overview extends
React.Component<Record<string, object>, IOverviewS
{deletePendingSummarytotalDeletedKeys !== undefined ?
deletePendingSummarytotalDeletedKeys: '0'} <span
className='ant-card-meta-description meta'>Total Pending Delete Keys</span>
</div>
);
+ const scmServiceData = (
+ <div>
+ Service Id: <span className="ant-card-meta-description meta"
style={{fontSize: "17px"}}>{scmServiceId}</span><br />
+ </div>
+ );
+ const omServiceData = (
+ <div>
+ Service Id: <span className="ant-card-meta-description meta"
style={{fontSize: "17px"}}>{omServiceId}</span>
+ </div>
+ );
Review Comment:
I think since it's separated, we can follow the format of the other overview
card (e.g. "Datanodes", "Volumes", etc). We can remove the "Service Id:" since
I find it a bit odd that the it is larger than the actual Service ID (e.g.
"omservice" is smaller than the "Service Id:" description).
<img width="1619" alt="image"
src="https://github.com/apache/ozone/assets/36403683/e3271e81-77fc-461b-8a6e-28e77ac40708";>
I think this can be achieved by just removing these lines and take directly
from the `omServiceId` and `scmServiceId` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
