smengcl commented on code in PR #6859:
URL: https://github.com/apache/ozone/pull/6859#discussion_r1674728440
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -146,6 +149,8 @@ public class BlockOutputStream extends OutputStream {
private final ContainerClientMetrics clientMetrics;
private boolean allowPutBlockPiggybacking;
+ private volatile CompletableFuture<Void> lastFlushFuture;
Review Comment:
`volatile` won't be necessary in this case because the access to this
variable is already in `synchronized` blocks.
```suggestion
private CompletableFuture<Void> lastFlushFuture;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
