duongkame commented on code in PR #6859:
URL: https://github.com/apache/ozone/pull/6859#discussion_r1677213463
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BufferPool.java:
##########
@@ -20,30 +20,45 @@
import java.nio.ByteBuffer;
import java.util.ArrayList;
+import java.util.LinkedList;
import java.util.List;
+import java.util.concurrent.locks.Condition;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantLock;
import java.util.function.Function;
+import java.util.function.Supplier;
+import com.google.common.annotations.VisibleForTesting;
import org.apache.hadoop.hdds.scm.ByteStringConversion;
import org.apache.hadoop.ozone.common.ChunkBuffer;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.util.Preconditions;
-
-import static java.util.Collections.emptyList;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
- * This class creates and manages pool of n buffers.
+ * A bounded pool implementation that provides {@link ChunkBuffer}s. This pool
allows allocating and releasing
+ * {@link ChunkBuffer}.
+ * This pool is designed for concurrent access to allocation and release. It
imposes a maximum number of buffers to be
+ * allocated at the same time and once the limit has been approached, the
thread requesting a new allocation needs to
+ * wait until a allocated buffer is released.
*/
public class BufferPool {
+ public static final Logger LOG = LoggerFactory.getLogger(BufferPool.class);
private static final BufferPool EMPTY = new BufferPool(0, 0);
-
- private final List<ChunkBuffer> bufferList;
- private int currentBufferIndex;
private final int bufferSize;
private final int capacity;
private final Function<ByteBuffer, ByteString> byteStringConversion;
+ private final LinkedList<ChunkBuffer> allocated = new LinkedList<>();
Review Comment:
I
[tried](https://github.com/apache/ozone/pull/6859/commits/53bc127fb95e6da644195122d26051f9213af3da).
But turns out we need to reserve the other of allocation to resend writeChunk
from allocated buffers when retrying, e.g. on container closed event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
