siddhantsangwan commented on PR #6967: URL: https://github.com/apache/ozone/pull/6967#issuecomment-2244800041
The latest commit also adds logic for transitioning a container from deleting to closed if a non-empty quasi-closed replica is reported. This covers the case when only quasi-closed replicas are remaining and others have been lost - the first corner case mentioned in the design document. Note that we don't have a check for comparing sequence ID of the container as known to SCM with the sequence ID of the quasi-closed replica. I don't think we should have the check because: 1. If quasi-closed replicas are the only ones left, we need to replicate them even if the sequence ID isn't the latest. 2. Non open containers only decrease in size, so if the quasi-closed replica is non-empty, we should close the container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
