errose28 commented on PR #7111: URL: https://github.com/apache/ozone/pull/7111#issuecomment-2316349111
@aswinshakil thanks for the changes. Overall just calling `ChunkManager#writeChunk` should handle the case for the file update, and we should propagate any exceptions. For additional functionality, the helper should determine whether overwrite is required or not based on the position of the chunkInfo relative to the current entry. I think this is what the TODO currently indicates. We may also want to verify that we do not leave gaps in the file. Additionally, we need to handle the case where we are appending to a chunk or block with new data this replica missed during write, and actually need to add checksums to the DB because they don't exist on this replica. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
