jojochuang commented on PR #7329: URL: https://github.com/apache/ozone/pull/7329#issuecomment-2429959049
@errose28 first of all the preExecute() doesn't specify what's expected to happen in there. So it can cause confusion for OMClientRequest implementations. Some kind of contract test would be great too. Second, I thought about fixing this request handler's preExecute() but I fear other preExecute() also have the similar problem and it's hard to catch them all, so I thought it's better to do a catch-all fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
