LsomeYeah commented on code in PR #5228:
URL: https://github.com/apache/paimon/pull/5228#discussion_r1989018033
##########
paimon-core/src/main/java/org/apache/paimon/iceberg/IcebergCommitCallback.java:
##########
@@ -752,7 +752,25 @@ private void expireAllBefore(long snapshotId) throws
IOException {
}
table.fileIO().deleteQuietly(listPath);
}
- table.fileIO().deleteQuietly(path);
+ deleteApplicableMetadataFiles(snapshotId);
Review Comment:
In `expireAllBefore` invoked by `createMetadataWithoutBase`, all the
iceberg manifest lists and manifest files for previous snapshots are deleted,
why still retain the previous metadata file?(if the relevant options had been
set)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
