junmuz commented on code in PR #5228:
URL: https://github.com/apache/paimon/pull/5228#discussion_r1990507064
##########
paimon-core/src/main/java/org/apache/paimon/iceberg/IcebergCommitCallback.java:
##########
@@ -752,7 +752,25 @@ private void expireAllBefore(long snapshotId) throws
IOException {
}
table.fileIO().deleteQuietly(listPath);
}
- table.fileIO().deleteQuietly(path);
+ deleteApplicableMetadataFiles(snapshotId);
Review Comment:
Yes, then in that cases it would be retained for auditing purposes only.
Once a new metadata is created, presence of old Iceberg metadata with all the
expired snapshots shouldn't be an issue for Iceberg Readers as latest metadata
file would always be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
