JingsongLi commented on code in PR #5670: URL: https://github.com/apache/paimon/pull/5670#discussion_r2113932999
########## paimon-core/src/main/java/org/apache/paimon/iceberg/IcebergCommitCallback.java: ########## @@ -935,10 +1085,99 @@ public void notifyDeletion(String tagName) { } } + // ------------------------------------------------------------------------------------- + // Deletion vectors + // ------------------------------------------------------------------------------------- + + private boolean needAddDvToIceberg() { Review Comment: Can you extract a field: `boolean needAddDvToIceberg`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org