JingsongLi commented on code in PR #5670:
URL: https://github.com/apache/paimon/pull/5670#discussion_r2113961984
##########
paimon-core/src/main/java/org/apache/paimon/iceberg/IcebergCommitCallback.java:
##########
@@ -388,28 +513,47 @@ private void createMetadataWithBase(
// because if a file's level is changed, it will first be removed and
then added.
// In this case, if `baseMetadata` already contains this file, we
should not add a
// duplicate.
- List<IcebergManifestFileMeta> newManifestFileMetas;
+ List<IcebergManifestFileMeta> newDataManifestFileMetas;
IcebergSnapshotSummary snapshotSummary;
if (isAddOnly) {
// Fast case. We don't need to remove files from `baseMetadata`.
We only need to append
// new metadata files.
- newManifestFileMetas = new ArrayList<>(baseManifestFileMetas);
-
newManifestFileMetas.addAll(createNewlyAddedManifestFileMetas(addedFiles,
snapshotId));
+ newDataManifestFileMetas = new
ArrayList<>(baseDataManifestFileMetas);
+ newDataManifestFileMetas.addAll(
+ createNewlyAddedManifestFileMetas(addedFiles, snapshotId));
snapshotSummary = IcebergSnapshotSummary.APPEND;
} else {
Pair<List<IcebergManifestFileMeta>, IcebergSnapshotSummary> result
=
createWithDeleteManifestFileMetas(
Review Comment:
Will the old DELETE entries manifests will be deleted here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@paimon.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
