Akash3121 commented on code in PR #10599:
URL: https://github.com/apache/paimon/pull/10599#discussion_r4290985781
##########
paimon-python/pypaimon/api/auth/dlf_openapi_actions.py:
##########
@@ -71,6 +71,8 @@
("POST", "/v1/{prefix}/views/rename", "RenameView"),
("GET", "/v1/{prefix}/databases/{database}/functions", "ListFunctions"),
("POST", "/v1/{prefix}/databases/{database}/functions", "CreateFunction"),
+ ("GET", "/v1/{prefix}/databases/{database}/function-details",
"ListFunctionDetails"),
+ ("GET", "/v1/{prefix}/functions", "ListFunctionsGlobally"),
Review Comment:
[P2] Cover pypaimon's rename_branch request as well
`pypaimon.api.rest_api.RESTApi.rename_branch` sends `POST
/v1/{prefix}/databases/{database}/tables/{table}/branches/{branch}/rename`, but
this table still has no matching action;
`test_openapi_v4_unregistered_requests_have_no_action` even asserts that it
resolves to None . With the openapi-v4 signer, that request therefore still
omits `x-acs-action` and is rejected by a gateway requiring the header. Please
add the registered action for this endpoint (or explicitly disable/document the
operation if DlfNext exposes no action), and add Python-side coverage that
invokes every public pypaimon REST request so future omissions fail CI just as
they now do for Java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
