sundapeng commented on code in PR #10599:
URL: https://github.com/apache/paimon/pull/10599#discussion_r4299985484
##########
docs/static/rest-catalog-open-api.yaml:
##########
@@ -3686,6 +3767,58 @@ components:
schemaId:
type: integer
format: int64
+ ReplaceTableRequest:
+ type: object
+ properties:
+ schema:
+ $ref: '#/components/schemas/Schema'
+ TableSchema:
+ type: object
+ properties:
+ version:
+ type: integer
+ format: int32
+ id:
+ type: integer
+ format: int64
+ fields:
+ type: array
+ items:
+ $ref: '#/components/schemas/DataField'
+ highestFieldId:
+ type: integer
+ format: int32
+ partitionKeys:
+ type: array
+ items:
+ type: string
+ primaryKeys:
+ type: array
+ items:
+ type: string
+ options:
+ type: object
+ additionalProperties:
+ type: string
+ comment:
+ type: string
+ timeMillis:
+ type: integer
+ format: int64
+ ListSchemasResponse:
+ type: object
+ properties:
+ schemas:
+ type: array
+ items:
+ $ref: '#/components/schemas/TableSchema'
+ nextPageToken:
+ type: string
Review Comment:
Thanks, fixed in 8a1d54d740. The same holds for every paged response whose
`nextPageToken` Jackson writes as `null`, so the spec now declares it as `[
string, "null" ]` on all 15 of them (`ListSchemasResponse`,
`ListDatabasesResponse`, `ListTablesResponse`, ...). The four that use
`@JsonInclude(NON_NULL)` and omit the token (`ListSemanticViewsResponse`,
`ListLabelsResponse`, `ListPermissionsResponse`, `ListPoliciesResponse`) keep a
plain string.
For the contract check, `PagedResponseSpecTest` serializes the last page of
every `PagedResponse` with `RESTApi.toJson` and fails when the spec has no
`nextPageToken` for it or rejects the null one. Against the previous spec it
reports all 15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
