lxy-9602 commented on code in PR #438:
URL: https://github.com/apache/paimon-cpp/pull/438#discussion_r4332192048
##########
src/paimon/core/operation/data_evolution_split_read.cpp:
##########
@@ -674,7 +676,203 @@ DataEvolutionSplitRead::SplitFieldBunches(
return fields_files;
}
Review Comment:
Could we also update `DataEvolutionFileStoreScan::EvolutionStats` for
independently rolled VECTOR files? It currently excludes only BLOB files, sorts
the remaining files by sequence number, and uses `entries[0].File()->row_count`
as the entire group’s row count.
For example, a main file contains 10,000 rows with 1,000 NULLs in `tag`. A
later full-range update of `embedding` produces independently rolled VECTOR
files of 1,000 rows each. A newer VECTOR file sorts first, so `tag IS NOT NULL`
is evaluated using the main file’s null count but the VECTOR file’s row count:
`1000 < 1000` is false. This incorrectly prunes the entire group, losing 9,000
matching rows.
Java computes the logical group row count and excludes BLOB/VECTOR files
from this statistics merge. Could we align this logic and add a regression test
covering newer rolled VECTOR files, nullable ordinary columns, and predicate
pruning?
##########
test/test_data/vortex/dedicated_vector_java_compat.db/dedicated_vector_java_compat/README.md:
##########
@@ -0,0 +1,58 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
Review Comment:
Please align the other READMEs by removing the license description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
