wangyong9999 commented on code in PR #374:
URL: https://github.com/apache/paimon-cpp/pull/374#discussion_r4356823076
##########
src/paimon/core/manifest/snapshot_live_manifest_entries.cpp:
##########
@@ -34,7 +34,7 @@
namespace paimon {
namespace {
-constexpr int32_t kMagic = 0x534d4543; // SMEC
+constexpr int32_t kMagic = 0x534d4544; // SMED: includes per-snapshot total
file counts
Review Comment:
`SnapshotCacheRebuildsCorruptValues` still writes the old magic
(`0x534d4543`) and omits `total_data_files`. With this format change, its
`version`, `truncated`, and `partition` cases all fail at the magic check, so
they no longer exercise the intended corruption/rebuild paths. Please update
that test payload to the new magic and insert the file count before the entry
count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
