wangyong9999 commented on code in PR #374:
URL: https://github.com/apache/paimon-cpp/pull/374#discussion_r4357256356
##########
src/paimon/core/manifest/snapshot_live_manifest_entries.cpp:
##########
@@ -34,7 +34,7 @@
namespace paimon {
namespace {
-constexpr int32_t kMagic = 0x534d4543; // SMEC
+constexpr int32_t kMagic = 0x534d4544; // SMED: includes per-snapshot total
file counts
Review Comment:
Validation update: the downstream Native harness rebuilt successfully with
this exact follow-up patch, and all 25 FileStoreScanTest /
AppendOnlyFileStoreScanTest cases passed, including
SnapshotCacheRebuildsCorruptValues. Full-tree pre-commit and diff checks
passed. Upstream CI still needs maintainer approval; the PR description records
this boundary and the existing compiler warnings. Resolving my own addressed
review threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
