rdblue commented on code in PR #3072:
URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2010869031
##########
parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java:
##########
@@ -56,6 +56,12 @@ protected LogicalTypeAnnotation fromString(List<String>
params) {
return listType();
}
},
+ VARIANT {
+ @Override
+ protected LogicalTypeAnnotation fromString(List<String> params) {
+ return variantType();
Review Comment:
Should this assert that there are no string params?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
