rdblue commented on code in PR #3072:
URL: https://github.com/apache/parquet-java/pull/3072#discussion_r2012413438
##########
parquet-column/src/test/java/org/apache/parquet/parser/TestParquetParser.java:
##########
@@ -447,4 +449,30 @@ public void testEmbeddedAnnotations() {
MessageType reparsed =
MessageTypeParser.parseMessageType(parsed.toString());
assertEquals(expected, reparsed);
}
+
+ @Test
+ public void testVARIANTAnnotation() {
+ String message = "message Message {\n"
+ + " required group aVariant (VARIANT) {\n"
+ + " required binary metadata;\n"
+ + " required binary value;\n"
+ + " }\n"
+ + "}\n";
+
+ MessageType expected = buildMessage()
+ .requiredGroup()
+ .as(LogicalTypeAnnotation.variantType())
+ .required(BINARY)
+ .named("metadata")
+ .required(BINARY)
+ .named("value")
+ .named("aVariant")
+ .named("Message");
+
+ MessageType parsed = parseMessageType(message);
Review Comment:
Variant shouldn't be added to `OriginalType`. The type annotations replace
`OriginalType` and we aren't adding anything else to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
