shangxinli commented on code in PR #3393:
URL: https://github.com/apache/parquet-java/pull/3393#discussion_r2937238135
##########
parquet-column/src/main/java/org/apache/parquet/column/statistics/Statistics.java:
##########
@@ -382,6 +411,11 @@ public void mergeStatistics(Statistics stats) {
mergeStatisticsMinMax(stats);
markAsNotEmpty();
}
+ if (isNanCountSet() && stats.isNanCountSet()) {
Review Comment:
Minor: should we also validate that both stats have the same column order
before merging? Merging IEEE 754 stats with TYPE_DEFINED_ORDER stats could
produce incorrect min/max since NaN handling differs. Though type.equals() on
line 408 may already cover this if column order is part of type equality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
