wgtmac commented on code in PR #3393:
URL: https://github.com/apache/parquet-java/pull/3393#discussion_r2973843438
##########
parquet-column/src/main/java/org/apache/parquet/column/statistics/FloatStatistics.java:
##########
@@ -99,6 +105,20 @@ public boolean isSmallerThan(long size) {
}
public void updateStats(float min_value, float max_value) {
+ if (type().columnOrder().equals(ColumnOrder.ieee754TotalOrder())) {
+ if (!Float.isNaN(min_value)) {
+ if (Float.isNaN(min) || comparator().compare(min, min_value) > 0) {
+ min = min_value;
+ }
+ }
Review Comment:
I've updated the spec to follow the total order. Now this implementation has
been changed to reflect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
