milastdbx commented on code in PR #560: URL: https://github.com/apache/parquet-format/pull/560#discussion_r3014865009
########## Geospatial.md: ########## @@ -85,19 +89,19 @@ associated with each point. The Z values introduce the third dimension coordinate. Usually they are used to indicate the height, or elevation. -M values are an opportunity for a geospatial instance to track a value in a -fourth dimension. These values can be used as a linear reference value (e.g., +M values are an opportunity for a geospatial instance to track a value in a +fourth dimension. These values can be used as a linear reference value (e.g., Review Comment: ```suggestion M values are an opportunity for a geospatial instance to track a value in a fourth dimension. These values can be used as a linear reference value (e.g., ``` ########## Geospatial.md: ########## @@ -85,19 +89,19 @@ associated with each point. The Z values introduce the third dimension coordinate. Usually they are used to indicate the height, or elevation. -M values are an opportunity for a geospatial instance to track a value in a -fourth dimension. These values can be used as a linear reference value (e.g., +M values are an opportunity for a geospatial instance to track a value in a +fourth dimension. These values can be used as a linear reference value (e.g., highway milepost value), a timestamp, or some other value as defined by the CRS. Bounding box is defined as the thrift struct below in the representation of min/max value pair of coordinates from each axis. Note that X and Y Values are always present. Z and M are omitted for 2D geospatial instances. -When calculating a bounding box, null or NaN values in a coordinate -dimension are skipped. For example, `POINT (1 NaN)` contributes a value to X -but no values to Y, Z, or M dimension of the bounding box. If a dimension has -only null or NaN values, that dimension is omitted from the bounding box. If -either the X or Y dimension is missing, then the bounding box itself is not +When calculating a bounding box, null or NaN values in a coordinate +dimension are skipped. For example, `POINT (1 NaN)` contributes a value to X +but no values to Y, Z, or M dimension of the bounding box. If a dimension has +only null or NaN values, that dimension is omitted from the bounding box. If +either the X or Y dimension is missing, then the bounding box itself is not Review Comment: ```suggestion When calculating a bounding box, null or NaN values in a coordinate dimension are skipped. For example, `POINT (1 NaN)` contributes a value to X but no values to Y, Z, or M dimension of the bounding box. If a dimension has only null or NaN values, that dimension is omitted from the bounding box. If either the X or Y dimension is missing, then the bounding box itself is not ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
