milastdbx commented on code in PR #560:
URL: https://github.com/apache/parquet-format/pull/560#discussion_r3021794568


##########
Geospatial.md:
##########
@@ -44,8 +44,49 @@ locations on Earth.
 The default CRS `OGC:CRS84` means that the geospatial features must be stored
 in the order of longitude/latitude based on the WGS84 datum.
 
-Custom CRS can be specified by a string value. It is recommended to use an
-identifier-based approach like [Spatial reference identifier][srid].
+Non-default CRS values are specified by any case insensitive string that 
uniquely identifies a coordinate reference system associated with this type.
+To maximize interoperability, suggested (but not limited to) formats for CRS 
are:
+* `authorithy:code` - where `authorithy` represents some well known 
authorities, and `code` is the code used by the authority to identify the CRS  
- examples are `OGC:CRS84`, `OGC:CRS83`, `OGC:CRS27`, `EPSG:4326`. See 
[https://spatialreference.org/](https://spatialreference.org/) for definitions 
coordinate reference systems provided by some well known authorities.
+* `srid:identifier` -  A reference using a [Spatial reference identifier 
(SRID)](https://en.wikipedia.org/wiki/Spatial_reference_system#Identifier), 
where identifier is the numeric SRID value. For example: `SRID:0`.
+* `projjson:table_property_name` - where `table_property_name` is a reference 
to a CRS definition in 
[PROJJSON](https://proj.org/en/stable/specifications/projjson.html), stored in 
the table property.
+* `projjson` - A complete CRS definition embedded directly using the 
[PROJJSON](https://proj.org/en/stable/specifications/projjson.html) 
specification. Example for OGC:CRS83:
+```
+{
+  "type": "GeographicCRS",
+  "name": "NAD83",
+  "datum": {
+    "type": "GeodeticReferenceFrame",
+    "name": "North American Datum 1983",
+    "ellipsoid": {
+      "name": "GRS 1980",
+      "semi_major_axis": 6378137,
+      "semi_minor_axis": 6356752.314140356,
+      "unit": "metre"
+    }
+  },
+  "coordinate_system": {
+    "subtype": "ellipsoidal",
+    "axis": [
+      {
+        "name": "Geodetic longitude",
+        "abbreviation": "Lon",
+        "direction": "east",
+        "unit": "degree"
+      },
+      {
+        "name": "Geodetic latitude",
+        "abbreviation": "Lat",
+        "direction": "north",
+        "unit": "degree"
+      }
+    ]
+  },
+  "id": {
+    "authority": "EPSG",
+    "code": 4269
+  }
+}

Review Comment:
   ```suggestion
   {
     "$schema": "https://proj.org/schemas/v0.7/projjson.schema.json";,
     "type": "GeographicCRS",
     "name": "NAD83 (CRS83)",
     "datum": {
       "type": "GeodeticReferenceFrame",
       "name": "North American Datum 1983",
       "ellipsoid": {
         "name": "GRS 1980",
         "semi_major_axis": 6378137,
         "inverse_flattening": 298.257222101
       }
     },
     "coordinate_system": {
       "subtype": "ellipsoidal",
       "axis": [
         {
           "name": "Geodetic longitude",
           "abbreviation": "Lon",
           "direction": "east",
           "unit": "degree"
         },
         {
           "name": "Geodetic latitude",
           "abbreviation": "Lat",
           "direction": "north",
           "unit": "degree"
         }
       ]
     },
     "scope": "Not known.",
     "area": "North America - onshore and offshore: Canada - Alberta; British 
Columbia; Manitoba; New Brunswick; Newfoundland and Labrador; Northwest 
Territories; Nova Scotia; Nunavut; Ontario; Prince Edward Island; Quebec; 
Saskatchewan; Yukon. Puerto Rico. United States (USA) - Alabama; Alaska; 
Arizona; Arkansas; California; Colorado; Connecticut; Delaware; Florida; 
Georgia; Hawaii; Idaho; Illinois; Indiana; Iowa; Kansas; Kentucky; Louisiana; 
Maine; Maryland; Massachusetts; Michigan; Minnesota; Mississippi; Missouri; 
Montana; Nebraska; Nevada; New Hampshire; New Jersey; New Mexico; New York; 
North Carolina; North Dakota; Ohio; Oklahoma; Oregon; Pennsylvania; Rhode 
Island; South Carolina; South Dakota; Tennessee; Texas; Utah; Vermont; 
Virginia; Washington; West Virginia; Wisconsin; Wyoming. US Virgin Islands. 
British Virgin Islands.",
     "bbox": {
       "south_latitude": 14.92,
       "west_longitude": 167.65,
       "north_latitude": 86.45,
       "east_longitude": -40.73
     },
     "id": {
       "authority": "OGC",
       "code": "CRS83"
     }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to