nssalian opened a new pull request, #565: URL: https://github.com/apache/parquet-format/pull/565
The `construct_variant` pseudocode in `VariantShredding.md` uses `.union()` without specifying result field ordering. This adds a comment cross-referencing VariantEncoding.md's requirement that object field IDs must be sorted lexicographically. I dug into the code and found that parquet-java already enforces this via `Collections.sort(fields)` in `VariantBuilder.endObject()`, verified by [TestReadVariant#testPartiallyShreddedObjectOutOfOrder](https://github.com/apache/parquet-java/blob/4c8f4d4b875259e2ece5f96c5ee90a03f78805ec/parquet-avro/src/test/java/org/apache/parquet/avro/TestReadVariant.java#L1035). Closes #506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
