emkornfield commented on code in PR #565:
URL: https://github.com/apache/parquet-format/pull/565#discussion_r3090088936
##########
VariantShredding.md:
##########
@@ -303,6 +303,8 @@ def construct_variant(metadata: Metadata, value: Variant,
typed_value: Any) -> V
assert typed_value.keys().isdisjoint(value.keys()), "object
keys must be disjoint"
# union the shredded fields and non-shredded fields
+ # (the result is a Variant object; field ID ordering rules
+ # from VariantEncoding.md apply)
Review Comment:
probably better to summarize them here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
