etseidl commented on code in PR #584:
URL: https://github.com/apache/parquet-format/pull/584#discussion_r3384433608
##########
src/main/thrift/parquet.thrift:
##########
@@ -1108,20 +1113,16 @@ union ColumnOrder {
* BOOLEAN - false, true
* INT32 - signed comparison
* INT64 - signed comparison
- * INT96 (only used for legacy timestamps) - undefined(+)
+ * INT96 (only used for legacy timestamps) - undefined or signed
comparison of the represented value(+)
* FLOAT - signed comparison of the represented value (*)
* DOUBLE - signed comparison of the represented value (*)
* BYTE_ARRAY - unsigned byte-wise comparison
* FIXED_LEN_BYTE_ARRAY - unsigned byte-wise comparison
*
* (+) While the INT96 type has been deprecated, at the time of writing it is
- * still used in many legacy systems. If a Parquet implementation chooses
- * to write statistics for INT96 columns, it is recommended to order them
- * according to the legacy rules:
- * - compare the last 4 bytes (days) as a little-endian 32-bit signed
integer
- * - if equal last 4 bytes, compare the first 8 bytes as a little-endian
- * 64-bit signed integer (nanos)
- * See https://github.com/apache/parquet-format/issues/502 for more
details
+ * still used in many legacy systems. It is recommended that writers use
Review Comment:
I think we should still make clear that writing INT96 statistics is
optional. If writers do choose to do so, then they should use this new
ColumnOrder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
