rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3397704351
##########
parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveType.java:
##########
@@ -655,6 +661,15 @@ public PrimitiveType
withLogicalTypeAnnotation(LogicalTypeAnnotation logicalType
return new PrimitiveType(getRepetition(), primitive, length, getName(),
logicalType, getId());
}
+ /**
+ * @param columnOrder the column order
+ * @return a new PrimitiveType with the same fields and the given column
order
+ */
+ public PrimitiveType withColumnOrder(ColumnOrder columnOrder) {
Review Comment:
If we always produce INT96 stats using the timestamp order, would we need
this addition to the API? I think we could always produce a `PrimitiveType`
with the right order when constructing types. We would just need to make sure
that deserialization correctly distinguishes between unordered and timestamp
order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
