rdblue commented on code in PR #3610:
URL: https://github.com/apache/parquet-java/pull/3610#discussion_r3397728800
##########
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java:
##########
@@ -2086,14 +2101,22 @@ Repetition fromParquetRepetition(FieldRepetitionType
repetition) {
return Repetition.valueOf(repetition.name());
}
- private static org.apache.parquet.schema.ColumnOrder
fromParquetColumnOrder(ColumnOrder columnOrder) {
+ private org.apache.parquet.schema.ColumnOrder
fromParquetColumnOrder(ColumnOrder columnOrder) {
if (columnOrder.isSetTYPE_ORDER()) {
return org.apache.parquet.schema.ColumnOrder.typeDefined();
}
+ if (columnOrder.isSetINT96_TIMESTAMP_ORDER() &&
readInt96TimestampStatisticsEnabled()) {
+ return org.apache.parquet.schema.ColumnOrder.int96TimestampOrder();
+ }
// The column order is not yet supported by this API
return org.apache.parquet.schema.ColumnOrder.undefined();
}
+ private boolean readInt96TimestampStatisticsEnabled() {
+ return options == null
+ ||
options.isEnabled(ParquetInputFormat.INT96_TIMESTAMP_STATISTICS_READING_ENABLED,
true);
Review Comment:
Why would we have an option for reading INT96 stats? Wouldn't this always be
true if we know the int96 stats are using the timestamp order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
