emkornfield commented on code in PR #588:
URL: https://github.com/apache/parquet-format/pull/588#discussion_r3455819695
##########
src/main/thrift/parquet.thrift:
##########
@@ -893,8 +880,13 @@ struct ColumnMetaData {
* whether we can decode those pages. **/
2: required list<Encoding> encodings
- /** Path in schema **/
- 3: required list<string> path_in_schema
+ /** Path in schema
+ *
+ * Made optional in parquet-format 3.0. If not written
+ * PARX magic number must be used (PATH_IN_SCHEMA_OMITTED, bit 1 in the
+ * feature flag bitmap, must be set).
+ **/
+ 3: optional list<string> path_in_schema
Review Comment:
> How far can and should we go in aligning the magic number, footer version,
and release version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
