gszadovszky commented on code in PR #3631:
URL: https://github.com/apache/parquet-java/pull/3631#discussion_r3459324754
##########
parquet-generator/src/main/java/org/apache/parquet/filter2/IncrementallyUpdatedFilterPredicateGenerator.java:
##########
Review Comment:
This branch still looks incorrect for `notIn` sets that contain null plus
non-null values. For example, `notIn(col, {null, 3.0})` will emit
`setResult(true)` for any non-null value, so a row where `col == 3.0` is still
kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
