wgtmac commented on code in PR #3631:
URL: https://github.com/apache/parquet-java/pull/3631#discussion_r3459772705
##########
parquet-generator/src/main/java/org/apache/parquet/filter2/IncrementallyUpdatedFilterPredicateGenerator.java:
##########
Review Comment:
Fixed in the latest push. The generated evaluator now handles null
membership only in updateNull(), and update(value) still scans the non-null
values with the column comparator. Added a regression test for in/notIn with
{null, 3.0}; notIn now rejects col == 3.0 and keeps only the non-matching
non-null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
