rdblue commented on code in PR #585:
URL: https://github.com/apache/parquet-format/pull/585#discussion_r3501066243
##########
src/main/thrift/parquet.thrift:
##########
@@ -468,6 +468,21 @@ struct GeographyType {
2: optional EdgeInterpolationAlgorithm algorithm;
}
+/**
+ * File logical type annotation
+ *
+ * Annotates a group that represents a reference to an external file.
+ * The group must contain the following fields identified by name:
+ * - path (STRING, required): an opaque string path to the file (e.g.
s3://bucket/file.jpg)
Review Comment:
I don't think this would be a forward-incompatible change. The FILE type
carries no guarantees about the lifecycle of the content it tracks. The file
this content lives in may be deleted out from under the reference.
Allowing a self-reference like this doesn't carry a requirement to preserve
blocks within a Parquet file and rewrite FILE references when carrying them
forward. That would conflict with the "no guarantee" point above and I don't
think anyone has (or would) suggest adding this as a requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
