brkyvz commented on code in PR #585:
URL: https://github.com/apache/parquet-format/pull/585#discussion_r3501496463
##########
src/main/thrift/parquet.thrift:
##########
@@ -468,6 +468,21 @@ struct GeographyType {
2: optional EdgeInterpolationAlgorithm algorithm;
}
+/**
+ * File logical type annotation
+ *
+ * Annotates a group that represents a reference to an external file.
+ * The group must contain the following fields identified by name:
+ * - path (STRING, required): an opaque string path to the file (e.g.
s3://bucket/file.jpg)
Review Comment:
I think a self reference like this feels very awkward. If data is supposed
to be inlined, I don't think it needs to live inside the File type in Parquet.
An engine can decide to store data as an inline record or an external file
reference. I think we should keep this format to external file references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
